Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )
Change subject: drivers/vpd: add framework to search VPD in romstage
......................................................................
Patch Set 20: Code-Review+1
(1 comment)
Just some nits, and thanks for all the effort.
It's so unfortunately the cache as SRAM is still not-easy-to-use on x86 and I think that's probably the best approach we may do.
https://review.coreboot.org/c/coreboot/+/34634/20/src/drivers/vpd/vpd_premem...
File src/drivers/vpd/vpd_premem.c:
https://review.coreboot.org/c/coreboot/+/34634/20/src/drivers/vpd/vpd_premem...
PS20, Line 26: struct vpd_blob
I'd prefer to use '*b' instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebdba59419a555147fc40391cf17cc6879d9e1b2
Gerrit-Change-Number: 34634
Gerrit-PatchSet: 20
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-Comment-Date: Fri, 30 Aug 2019 02:58:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment