Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42502/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42502/2//COMMIT_MSG@7 PS2, Line 7: google
mb/google
Done
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG@7 PS3, Line 7: mb/google
mb/google/kukui
Done
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG@13 PS3, Line 13: TEST=Boots correctly and stress test passes on Kukui.
Please add the command of the stress test.
Done
https://review.coreboot.org/c/coreboot/+/42502/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c:
https://review.coreboot.org/c/coreboot/+/42502/3/src/mainboard/google/kukui/... PS3, Line 2: /* This file is part of the coreboot project. */
I believe the second line can be dropped.
Done