Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal, Rizwan Qureshi.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77174?usp=email )
Change subject: soc/intel/cmn/cse: Refactor CSE RW FW Version implementation ......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/77174/comment/1c16257e_4774197b : PS4, Line 219: info->crc
This isn't correct, a CRC of 0x00000000 may be valid (in one out of 2^32 cases).
Acknowledged
https://review.coreboot.org/c/coreboot/+/77174/comment/5a4f24d3_25220afc : PS4, Line 253: memcpy(&(info->cse_fwp_version.cur_cse_fw_version), &(cse_bp->fw_ver),
This isn't the entire `struct cse_specific_info`, right? So you then need to zero (or otherwise clea […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/77174/comment/bf5cd79b_657184f1 : PS4, Line 263: CONFIG(SOC_INTEL_STORE_CSE_FW_VERSION)
nit: would be slightly more efficient to have this as an #if around this whole function and the CBMEM_CREATION_HOOK line instead.
done