Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63989 )
Change subject: mb/ocp, soc/intel/xeon_sp: Use common ASL POST defines ......................................................................
mb/ocp, soc/intel/xeon_sp: Use common ASL POST defines
Use common ASL defines for POST code handling.
Change-Id: I5b4c11860a8c33e56edaea0f6de378cbaa63a8c5 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/63989 Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/deltalake/acpi/platform.asl M src/mainboard/ocp/tiogapass/acpi/platform.asl M src/soc/intel/xeon_sp/acpi/iiostack.asl 3 files changed, 3 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved Jonathan Zhang: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/ocp/deltalake/acpi/platform.asl b/src/mainboard/ocp/deltalake/acpi/platform.asl index fa6a451..5a15b29 100644 --- a/src/mainboard/ocp/deltalake/acpi/platform.asl +++ b/src/mainboard/ocp/deltalake/acpi/platform.asl @@ -21,13 +21,7 @@ APMS, 8 // APM status }
-/* Port 80 POST */ -OperationRegion (DBG0, SystemIO, 0x80, 0x02) -Field (DBG0, ByteAcc, Lock, Preserve) -{ - IO80, 8, - IO81, 8 -} +#include <arch/x86/acpi/post.asl>
/* IO-Trap at 0x800. * This is the ACPI->SMI communication interface. diff --git a/src/mainboard/ocp/tiogapass/acpi/platform.asl b/src/mainboard/ocp/tiogapass/acpi/platform.asl index 9f51fdf..782d2cd 100644 --- a/src/mainboard/ocp/tiogapass/acpi/platform.asl +++ b/src/mainboard/ocp/tiogapass/acpi/platform.asl @@ -21,13 +21,7 @@ APMS, 8 // APM status }
-/* Port 80 POST */ -OperationRegion (DBG0, SystemIO, 0x80, 0x02) -Field (DBG0, ByteAcc, Lock, Preserve) -{ - IO80, 8, - IO81, 8 -} +#include <arch/x86/acpi/post.asl>
/* IO-Trap at 0x800. * This is the ACPI->SMI communication interface. diff --git a/src/soc/intel/xeon_sp/acpi/iiostack.asl b/src/soc/intel/xeon_sp/acpi/iiostack.asl index 4b2b65b..73f9937 100644 --- a/src/soc/intel/xeon_sp/acpi/iiostack.asl +++ b/src/soc/intel/xeon_sp/acpi/iiostack.asl @@ -58,7 +58,7 @@ { \ /* indicate unrecognized UUID */ \ CDW1 |= 0x04 \ - IO80 = 0xEE \ + DBG0 = 0xEE \ Return (Arg3) \ } \ } \