[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/nissa/var/pujjoga: Tune SX9324 register

[Paul Menzel (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Leo Chou, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik.

Paul Menzel has posted comments on this change by Leo Chou. ( https://review.coreboot.org/c/coreboot/+/82689?usp=email )

Change subject: mb/google/nissa/var/pujjoga: Tune SX9324 register
......................................................................

Patch Set 3:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82689/comment/c685e48d_3c52530a?usp... :
PS3, Line 7: register
register*s*?

https://review.coreboot.org/c/coreboot/+/82689/comment/9088b236_7127b3db?usp... :
PS3, Line 7: Tune SX9324 register
Tune for what goal?

https://review.coreboot.org/c/coreboot/+/82689/comment/b7b82535_6d4c6a55?usp... :
PS3, Line 9: Update SX9324 register settings
`select DRIVERS_I2C_SX9324` suggests, it wasn’t used before. So “Update” sounds wrong?

https://review.coreboot.org/c/coreboot/+/82689/comment/31c13adf_a37eb1b5?usp... :
PS3, Line 12: =Check i2c register settings on Pujjoga
How?

https://review.coreboot.org/c/coreboot/+/82689/comment/218d5af6_8a68c949?usp... :
PS3, Line 13: confirm P sensor function can work
Did it work before this commit?

https://review.coreboot.org/c/coreboot/+/82689/comment/443411b2_6c4502a5?usp... :
PS3, Line 14: 
What Linux kernel driver was used?