Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce and use FIXED BARs_ADDRESS symbols ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig@525 PS14, Line 525: .bars
sorry, forget to mention that we can just rename "Kconfig.bars" as "Kconfig". […]
Ah, got it. I did only think about the help texts, not menuconfig's search function. Maybe we should restrict the latter to show only configs with a prompt? Is it useful to show invisible configs in search results? It seems a bit overkill to order Kconfig files just for the search results.
If we want to fix the order, we should make it visible in the file name why we do it. If it's called `.bars` nobody will expect it to be about Kconfig order. How about `Kconfig.decl` for declarations? And then just do
source "src/northbridge/*/common/Kconfig.decl" source "src/northbridge/*/*/Kconfig"
and if needed, add later
source "src/northbridge/*/common/Kconfig.common"
(or maybe `Kconfig.defaults` for the latter?)
Angel, what do you think?
Btw. right about the alphabetic order but that would be coincidence and fragile.