[coreboot-gerrit] [M] Change in coreboot[master]: drivers/vpd, cpu/x86/smm: Add VPD support for SMM

[Arthur Heymans (Code Review)]

Attention is currently required from: Arthur Heymans, Marc Jones, Subrata Banik, Johnny Lin, Ed Sharma, Christian Walter, Shuming Chu (Shuming), Michael Niewöhner, Kyösti Mälkki.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67092 )

Change subject: drivers/vpd, cpu/x86/smm: Add VPD support for SMM
......................................................................

Patch Set 4:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/67092/comment/7b700590_d9ccc1ed 
PS4, Line 9: The main purpose is to be able to dynamically configure system during
           : SMM boot time via VPD.
It does way more than fulfill that purpose. The os could in principle also update the memory of that CBMEM region. Do you trust the SMM code enough that it will properly handle malformed input? It's not a safe thing to do so if your goal is to only have some boot time configuration, then you want a different mechanism than bloating the runtime. I suggest passing your configuration just like you pass the cbmemc buffer.