Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro.
Paul Menzel has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/87286?usp=email )
Change subject: mb/google/brya: Optimize CBFE backed option API ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87286/comment/09e34546_a74c07d5?usp... : PS4, Line 7: CBFE CBF*S*
https://review.coreboot.org/c/coreboot/+/87286/comment/bd93b9f1_2c824706?usp... : PS4, Line 9: Added Add
https://review.coreboot.org/c/coreboot/+/87286/comment/a3b771ae_f598ba55?usp... : PS4, Line 9: traversal Of what?
https://review.coreboot.org/c/coreboot/+/87286/comment/8e69a6f2_009e9fef?usp... : PS4, Line 10: look up lookup
https://review.coreboot.org/c/coreboot/+/87286/comment/a4daa0b4_fdb4a1ab?usp... : PS4, Line 10: then th*a*n
https://review.coreboot.org/c/coreboot/+/87286/comment/b52031cf_44f94443?usp... : PS4, Line 16: TEST=Verify option filter logic. Please add the measurements without and with your patch.
File src/mainboard/google/brya/common.c:
https://review.coreboot.org/c/coreboot/+/87286/comment/1187e4bd_6f101989?usp... : PS4, Line 19: int size_t