Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: {mb,soc/intel/skylake}: Update GFX devtree options
......................................................................
Patch Set 7:
(1 comment)
I read about the Librem article
that was the original model, never ported to coreboot. Every model since has coreboot support and only has Intel iGPU, and no capability to use an external or dGPU. So I think defaulting to iGFX makes sense for them
https://review.coreboot.org/#/c/32044/6/src/mainboard/purism/librem_skl/vari...
File src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb:
https://review.coreboot.org/#/c/32044/6/src/mainboard/purism/librem_skl/vari...
PS6, Line 61: register "PrimaryDisplay" = "Display_Auto"
why are we setting the Librems (and other non-Chromebooks) to Auto here (which was the previous default when unset), but setting Chromebooks to iGFX (via the new enum default)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 7
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 01 Apr 2019 21:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment