Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45334 )
Change subject: mb/google/zork: Set USB3 port to force gen1 for morphius and ezkinil
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45334/16/src/mainboard/google/zork/...
File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45334/16/src/mainboard/google/zork/...
PS16, Line 26: .ports.xhci0_port1 = 1, /* Left USB3A port 1 */
: .ports.xhci0_port2 = 1, /* Left USB3A port 2 */
if i remember correctly all devices i looked at only had at most one type a and one type c port on each side, so i wonder if this device really has two type a ports on one side
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10419b91fe86fe3e06de36ddfe0d1769c1031f8e
Gerrit-Change-Number: 45334
Gerrit-PatchSet: 16
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Oct 2020 14:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment