Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40515 )
Change subject: ec/google/chromeec: Add driver for i2c_tunnel device under Chrome EC
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40515/7/src/ec/google/chromeec/i2c_...
File src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c:
https://review.coreboot.org/c/coreboot/+/40515/7/src/ec/google/chromeec/i2c_...
PS7, Line 39: CROS_EC_I2C_TUNNEL_DDN
WDYT about using the acpi_device_name ?
https://review.coreboot.org/c/coreboot/+/40515/7/src/ec/google/chromeec/i2c_...
PS7, Line 51: IT%02.2X
Just a suggestion, maybe TUNx? Do you think we'd ever use more than 10 tunnels per EC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfc0ec3725d7f1d20bcb5cb43a0a23aac72bf4eb
Gerrit-Change-Number: 40515
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Apr 2020 20:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
