Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41899 )
Change subject: device/xhci: Add xHCI utility to enumerate capabilities
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41899/3/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/41899/3/src/device/Kconfig@814
PS3, Line 814: config XHCI_UTILS
: def_bool n
: help
: Provides xHCI utility functions.
In my opinion, we don't really need a Kconfig option to control this. If it is unused, linker should take care of optimizing it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3065c3fffad01b5378a55cfe904f971079b13d0f
Gerrit-Change-Number: 41899
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Jun 2020 19:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment