EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35881 )
Change subject: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR
......................................................................
Patch Set 3:
(2 comments)
Thanks. Please help cherry-pick to ToT.
https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu...
PS1, Line 29: PAD_NC(GPIO_138, UP_20K),
Seems to be no harmful if we follow the baseboard gpio so would be fine with it.
Ack
https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu...
PS1, Line 32: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),
If so, I would suggest to follow Octopus - yorp baseboard design because there are a lot of projects […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28cef592374fb4aeee2f3d3010cc0e237d62a2fd
Gerrit-Change-Number: 35881
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Jasper Lee
jasper_lee@compal.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 11:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Gerrit-MessageType: comment