Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41674 )
Change subject: soc/intel/common/{pch,sata}: Remove SATA common code driver
......................................................................
Patch Set 6:
Patch Set 6:
So, lets get this driver drop now ? we do have any objection from SKL/KBL users still ?
I would like to clarify this with the guys from facebook.
@Andrew, @David, @Jonathan, please tell us, can SATA in the Lewisburg C62x chipset work without this driver? Can we abandon CB:39918?
Valid ask, i was thinking if its still must for SPT PCH, we shall only select the required SoC Kconfig and not from common PCH Kconfig.
Will wait for complete test report from Intel/Matt/FB folks. Thanks for taking this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied3832b26ba1fdd4c30fafe8149689a01d302c3e
Gerrit-Change-Number: 41674
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 31 May 2020 15:41:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment