Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move weak mainboard_get_dram_part_num implementation to lib/spd_bin.c ......................................................................
Patch Set 20:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45588/20/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45588/20/src/lib/spd_bin.c@146 PS20, Line 146: char spd_name[] This is not really required anymore. You can just return &spd[offset];
where offset is dependent on dram_type.
https://review.coreboot.org/c/coreboot/+/45588/20/src/mainboard/google/deded... File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/45588/20/src/mainboard/google/deded... PS20, Line 35: (const char *) Typecast not really required here and in other files.
https://review.coreboot.org/c/coreboot/+/45588/20/src/soc/intel/elkhartlake/... File src/soc/intel/elkhartlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45588/20/src/soc/intel/elkhartlake/... PS20, Line 24: const char *mainboard_get_dram_part_num(void) : { : /* Default implementation, no need to override part number. */ : return NULL; : } This is no longer required. This platform seems to have missed adding __weak to the function originally.