4 Oct
2019
4 Oct
'19
4:02 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35539 )
Change subject: acpi_table_header: Replace hard-coded revision via macro and function ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35539/2/src/mainboard/portwell/m107... File src/mainboard/portwell/m107/fadt.c:
https://review.coreboot.org/c/coreboot/+/35539/2/src/mainboard/portwell/m107... PS2, Line 28: header->revision = ACPI_FADT_REV_ACPI_2_0;
hard coded number was 3, but this is 2. […]
The encoding is weird: src/arch/x86/include/arch/acpi.h:#define ACPI_FADT_REV_ACPI_2_0 3
--
To view, visit https://review.coreboot.org/c/coreboot/+/35539
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99e59afc1a87203499d2da6dedaedfa643ca7eac
Gerrit-Change-Number: 35539
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment