Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45789 )
Change subject: soc/intel: Move pch_misc_init() to common code
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45789/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45789/8//COMMIT_MSG@12
PS8, Line 12: Removes
nit: Remove
Ack
https://review.coreboot.org/c/coreboot/+/45789/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/45789/8/src/soc/intel/common/block/...
PS8, Line 396: 0x61
For another patch: Use macros for these registers
sure, will make it clean in another patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie36ee63869c076d251ccfa5409001d18f22600d7
Gerrit-Change-Number: 45789
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 09:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment