Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37258 )
Change subject: Add compatibility mode ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
just suggestions
https://review.coreboot.org/c/em100/+/37258/1/image.c File image.c:
https://review.coreboot.org/c/em100/+/37258/1/image.c@97 PS1, Line 97: const fcba_t *fcba = find_fcba(image, size); : const fdbar_t *fdb = find_fd(image, size); Should these two be cached? They're looked up a couple of times
https://review.coreboot.org/c/em100/+/37258/1/image.c@120 PS1, Line 120: ifd_version maybe return instead of using a global?
https://review.coreboot.org/c/em100/+/37258/1/image.c@125 PS1, Line 125: set_spi_frequency prefix with ifd_ to make clear that it's ifd specific?
https://review.coreboot.org/c/em100/+/37258/1/image.c@141 PS1, Line 141: set_em100_mode ditto