Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48324 )
Change subject: Revert "cbfs: Introduce cbfs_ro_map() and cbfs_ro_load()"
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-2
Sorry, this revert isn't justified. Instead, consider selecting NO_CBFS_MCACHE in Kconfig for the affected platforms. Thank you for your comprehension.
Although selecting NO_CBFS_MCACHE worked, I'm puzzled why exactly this commit breaks ASUS AM1I-A board - and not CB:38424 which enabled the MCACHE. That probably means something isn't right with this commit - just like my earlier CB:41431 which somehow works for fam15h but doesn't for fam16h. So I still think this commit should be reverted, but I will happy to test any workarounds on top of it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e092c966da60deae21d19eb4053628541595bbb
Gerrit-Change-Number: 48324
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Dec 2020 16:27:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment