[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common/block/gpio: Add gpio_pm_configure() function

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )

Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/include/i... 
File src/soc/intel/common/block/include/intelblocks/gpio.h:

https://review.coreboot.org/#/c/32788/6/src/soc/intel/common/block/include/i... 
PS6, Line 25: 
            : union gpio_misc_pm {
            : 	uint8_t config;
            : 	struct {
            : 		uint8_t gdlcgen : 1;
            : 		uint8_t gpdpcgen : 1;
            : 		uint8_t gsxslcgen : 1;
            : 		uint8_t gprtcdlcgen : 1;
            : 		uint8_t gprcompcdlcgen : 1;
            : 		uint8_t gpsidedpcgen : 1;
            : 		uint8_t reserved : 2;
            : 	} bit;
            : };
            :
> for chip. […]

Should we just have macros here?
GDLCGEN (1 << 0)
GPDPCGEN (1 << 1)
...

Those can be then used directly in devicetree?