Attention is currently required from: Martin L Roth, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67099 )
Change subject: drivers/i2c: Add a new RTC RV-3028-C7 from Micro Crystal ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67099/comment/9b3c11fc_b43597d3 PS3, Line 12: devietree
devicetree
Ack
Patchset:
PS3: Thanks for the review Martin.
File src/drivers/i2c/rv3028c7/chip.h:
https://review.coreboot.org/c/coreboot/+/67099/comment/0fcd2b98_0d57d1d7 PS3, Line 2:
Add guards around header file?
Looks like a lot of chip.h files in the tree do no use the guards. But a lot do, so I will add them here.
https://review.coreboot.org/c/coreboot/+/67099/comment/e1d02a00_11efce39 PS3, Line 28: CARGE_VIA_3K
CHARGE_? Same below.
Ack
https://review.coreboot.org/c/coreboot/+/67099/comment/2b698aea_d9844e4b PS3, Line 38: /* User year to set */
/* User year to set (2-digit) */
Ack
https://review.coreboot.org/c/coreboot/+/67099/comment/506c66d8_12b7866a PS3, Line 41: cap_cahrge
cap_charge?
Ack
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/67099/comment/5bea0230_fed2f445 PS3, Line 22: } while ((status & EE_BUSY_BIT) && !stopwatch_expired(&sw));
Add a 1ms delay here so this time can be used elsewhere if needed? […]
Sounds good, will add.