[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )

Change subject: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45177/3/src/soc/amd/picasso/dmi.c 
File src/soc/amd/picasso/dmi.c:

https://review.coreboot.org/c/coreboot/+/45177/3/src/soc/amd/picasso/dmi.c@2... 
PS3, Line 21: static uint16_t convert_speed_mhz_to_mts(uint16_t speed_mhz)
> I refactored the code to use a table of tCK. […]

Yes, we should move this to ddr4.[c|h]. But, as mentioned on the latest patchset, I think the function can be simpler by having a table with min,max for Mhz and the expected MT/s for that range.