[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Add support for USB Type-C ports

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40425 )

Change subject: mb/google/volteer: Add support for USB Type-C ports
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/acpi/usbc.asl:

PS1:
> +1 would love for this to be auto-generated.

Couple of things. +1 to Caveh, this pretty much has to be generated at runtime. Also, why are the sbu-orientation and hsl-orientation static (i.e. a Package)? Are they intended to just be the orientations discovered at boot time, or should this be a Method, which can determine the correct setting when it's called?