21 May
2019
21 May
'19
5:43 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32905 )
Change subject: RFC: smbios: allow setting BIOS-version string from VPD variable ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32905/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32905/2/src/arch/x86/smbios.c@358 PS2, Line 358: /* if found, vpd value will be terminated by 0x00 (VPD_TYPE_TERMINATOR) */ line over 80 characters
https://review.coreboot.org/#/c/32905/2/src/arch/x86/smbios.c@359 PS2, Line 359: if(coreboot_vpd_version) space required before the open parenthesis '('
--
To view, visit https://review.coreboot.org/c/coreboot/+/32905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0e9d90ed0941c4e76e3e48cdcccf830ef789458
Gerrit-Change-Number: 32905
Gerrit-PatchSet: 2
Gerrit-Owner: Łukasz Siudut
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 May 2019 03:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment