Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35149 )
Change subject: mb/google/kahlee/variants/careena: override DRAM SPD table
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35149/3/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/careena/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35149/3/src/mainboard/google/kahlee...
PS3, Line 17: $(CONFIG_VARIANT_DIR)
You could point this at the baseboard SPD directory and not have to copy the files. […]
Hi Martin, done, please help review patch#4. Thank you!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35149
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1b2c1bae5ffe9f3a6a6560348f6e1b117ffd457
Gerrit-Change-Number: 35149
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 06:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment