Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47804 )
Change subject: soc/intel/elkhartlake: Fix EHL mainboard build fail errors
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47804/2/src/soc/intel/elkhartlake/i...
File src/soc/intel/elkhartlake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/47804/2/src/soc/intel/elkhartlake/i...
PS2, Line 7: #include <intelblocks/gpio.h>
This file per sé does not need any include at all. Wouldn't it be better to include the needed files where they are realy used and maintain the order there?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idaa8b0b5301742287665abde065ad72965bc62b3
Gerrit-Change-Number: 47804
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 06:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment