Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34752/17/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/34752/17/src/Kconfig@1239
PS17, Line 1239: depends on ARCH_X86 && RELOCATABLE_RAMSTAGE
This also depends on !x86-64 ramstage since the implication is that ramstage is entered with CAR still enabled.
https://review.coreboot.org/c/coreboot/+/34752/17/src/lib/program.ld
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/34752/17/src/lib/program.ld@99
PS17, Line 99: */
I think we should be explicit in the commenting how exit_car.S needs this section for obtaining the stack value. ENV_POSTCAR and RAMSTAGE_LOADS_FROM_ROMSTAGE both need this section because exit_car.S is the stage entry point which needs that information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc88e6727b2fa692585dffe576e69f6d4d0b349d
Gerrit-Change-Number: 34752
Gerrit-PatchSet: 17
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 11 Sep 2019 19:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment