HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43283 )
Change subject: src: Remove redundant use of ACPI offset(0) ......................................................................
Patch Set 4:
(3 comments)
Thx
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/compal/ene932/acpi/e... File src/ec/compal/ene932/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/compal/ene932/acpi/e... PS4, Line 19: , 1, // Reserved ; 00h.0
I think the leading comma is confusing (didn't notice before I am sorry)
that comma is needed.
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/roda/it8518/acpi/ec.... File src/ec/roda/it8518/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/ec/roda/it8518/acpi/ec.... PS4, Line 17: /
I guess I was wrong here, now the comment doesn't really make sense any more
Done
https://review.coreboot.org/c/coreboot/+/43283/4/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/43283/4/src/soc/intel/cannonlake/ac... PS4, Line 26: /*
I guess the comment should be behind the entry here
Done