Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 1:
(2 comments)
It looks like the UEFI image puts the two Models 60h-6Fh in a table pointed to by offset 0x10 and the 70h-7Fh in a separate table pointed to by offset 0x14. The 2 older ones include both, not either-or. They use the submodel to distinguish between the two (same as RV2 and PCO in soc//picasso). While we don't currently build two separate tables, I'm starting to think we should consider making the amdfwtool arguments more overt instead of one-size-fits-all.
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@16 PS1, Line 16: only Stoneyridge is combo capable To be more clear, we never build combo directories. It's that the 0x14th location points to a directory table that may be tradition or it may be combo. We use the --combo-capable argument to simply say use offset 0x14 for the pointer, not the older 0x10.
Combo capable was explicitly developed for Google.
Sorry, but the phone range before I hit Send on the comment above. But no, Google is not part of this topic in any way. I have no idea what you're confusing this with. The ability to load SMU firmware on the fly?
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@18 PS1, Line 18: Merlin Falcon uses the same internal CPU as Carrizo, thus it has dual memory : channel while Prairie Falcon and Stoney ridge have only one channel.
I just wanted to differentiate between Merlin Falcon and Prairie Falcon. […]
It's not that the comparison is invalid. It's that it's not relevant to the patch and will likely confuse the reader if they try to fully understand the purpose of your changes in the source code, which is only about building in the incorrect binaries on a per-product basis. That has nothing to do with number of channels, etc.