Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: soc/amd/common: Access ACPIMMIO via proper symbols ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37324/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37324/12//COMMIT_MSG@10 PS12, Line 10: addesses add*r*esses
https://review.coreboot.org/c/coreboot/+/37324/12/src/soc/amd/common/block/g... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/37324/12/src/soc/amd/common/block/g... PS12, Line 183: inter_master = (void *)acpimmio_gpio0 + GPIO_MASTER_SWITCH;
i'm being pedantic, but we can we please not do arithmetic on void * pointers?
if acpimmio has a fixed format, how about using a memory-mapped struct? Or would that be too cursed?