11 Feb
2021
11 Feb
'21
1:46 p.m.
Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, EricR Lai, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50450 )
Change subject: mb/google/guybrush: Second pass GPIO configuration ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50450/comment/c9bc294d_d7f18f87 PS2, Line 7: mb/google/guybrush: Second pass GPIO configuration Please make it a statement by adding a verb in imperative mood.
https://review.coreboot.org/c/coreboot/+/50450/comment/79d86d40_dc097880 PS2, Line 9: guybrush reference : schematic Does it have a version?
--
To view, visit https://review.coreboot.org/c/coreboot/+/50450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fdc4d7369353f88cf05e2e1ec08898d4605e602
Gerrit-Change-Number: 50450
Gerrit-PatchSet: 2
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Mathew King mathewk@chromium.org
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 20:46:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment