Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60290 )
Change subject: util/amdfwtool: Generate hashes for signed AMDFW components ......................................................................
Patch Set 4:
(3 comments)
File util/amdfwtool/amdfwtool.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157974): https://review.coreboot.org/c/coreboot/+/60290/comment/8a4c7718_f6f13a86 PS4, Line 328: } __attribute__((packed)); Prefer __packed over __attribute__((packed))
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157974): https://review.coreboot.org/c/coreboot/+/60290/comment/a2ec84c8_156de4f6 PS4, Line 811: write_or_fail(fd, fw_table[i].hash_entries[j].sha, SHA256_DIGEST_LENGTH); line length of 105 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157974): https://review.coreboot.org/c/coreboot/+/60290/comment/ce14c399_af60920c PS4, Line 823: write_or_fail(fd, fw_table[i].hash_entries[j].sha, SHA384_DIGEST_LENGTH); line length of 105 exceeds 96 columns