Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35364 )
Change subject: drivers/intel/fsp2_0: Add NULL pointer debug messages to UPD
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35364/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35364/1//COMMIT_MSG@9
PS1, Line 9: Check for a NULL pointer before displaying UPD information in case
: the new area wasn't allocated.
I am curious to understand the motivation behind this. […]
I see now that you are changing the behavior for FSP_S such that new could be NULL. But, I don't think it is a valid case. Please see my comments on following CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28febfb04c2e5e68c43a0db499686bbbcd80afef
Gerrit-Change-Number: 35364
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Sep 2019 01:12:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment