Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42505 )
Change subject: libpayload: Initialize video console conditionally ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42505/1/payloads/libpayload/gdb/stu... File payloads/libpayload/gdb/stub.c:
https://review.coreboot.org/c/coreboot/+/42505/1/payloads/libpayload/gdb/stu... PS1, Line 76: puts("GDB died, redirecting its last words to the screen:\n"); No, this is supposed to be visible on the screen, so it needs to come after video_console_init(). (It's okay to move it into that conditional.)