[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Add SPI GPIO driving setting

[Mengqi Zhang (Code Review)]

Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )

Change subject: mediatek/mt8183: Add SPI GPIO driving setting
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32460/6/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/32460/6/src/soc/mediatek/mt8183/gpio.c@170 
PS6, Line 170: 	clrsetbits_le32(reg, 0xf << offset, reg_val << offset);
> I don't think this works. […]

Done