[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Introduce SKU_ID helpers

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )

Change subject: ec/google/chromeec: Introduce SKU_ID helpers
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/Kcon... 
File src/ec/google/chromeec/Kconfig:

https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/Kcon... 
PS4, Line 103: # set to 0xff for LEGACY
             : config EC_GOOGLE_CHROMEEC_SKUID_MAX
             : 	hex
             : 	default 0x7fffffff
I don't think this is required anymore?

https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_b... 
File src/ec/google/chromeec/ec_boardid.c:

https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_b... 
PS4, Line 18: #include <console/console.h>
            : #include <string.h>
Are these still required?