Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37168 )
Change subject: src/southbridge/amd/pi/hudson: add southbridge C bootblock initialization ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... PS1, Line 31: : ifeq ($(CONFIG_C_ENVIRONMENT_BOOTBLOCK),y) guarding should not be needed.
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... PS1, Line 64: #if CONFIG(C_ENVIRONMENT_BOOTBLOCK) put it in a different file?