Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35009 )
Change subject: default.fmd: reserve space for the ffs headers
......................................................................
Patch Set 4:
(2 comments)
Patch Set 4: Code-Review+1
Looks good aside from the comment nits.
...which didn't save the first time around... :)
https://review.coreboot.org/c/coreboot/+/35009/4/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35009/4/Makefile.inc@967
PS4, Line 967: NON_X86
Will this be used for all non-x86 systems or should it call out ppc explicitly?
https://review.coreboot.org/c/coreboot/+/35009/4/Makefile.inc@1027
PS4, Line 1027: NON_X86
Ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I184efae6860a9a2e3cf6a39b9d0df2a6c3e943d4
Gerrit-Change-Number: 35009
Gerrit-PatchSet: 4
Gerrit-Owner: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 25 Aug 2019 07:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment