build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26461 )
Change subject: src: Use "foo *bar" instead of "foo* bar" ......................................................................
Patch Set 3:
(23 comments)
https://review.coreboot.org/#/c/26461/3/src/drivers/amd/agesa/eventlog.c File src/drivers/amd/agesa/eventlog.c:
https://review.coreboot.org/#/c/26461/3/src/drivers/amd/agesa/eventlog.c@89 PS3, Line 89: const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED", char * array declaration might be better as static const
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h File src/northbridge/amd/amdht/h3finit.h:
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 229: * @param[in,out] u8 *LinkWidthIn = modify to change the Link Witdh In line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 230: * @param[in,out] u8 *LinkWidthOut = modify to change the Link Witdh Out line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 231: * @param[in,out] u32 *FreqCap = modify to change the link's frequency capability line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 232: * @param[in,out] u32 *FeatureCap = modify to change the link's feature capability line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 269: * @param[in,out] u8 *ABLinkWidthLimit = modify to change the Link Witdh In line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 270: * @param[in,out] u8 *BALinkWidthLimit = modify to change the Link Witdh Out line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 271: * @param[in,out] u32 *PCBFreqCap = modify to change the link's frequency capability line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 302: * @param[in,out] u8 *DownstreamLinkWidthLimit = modify to change the Link Witdh In line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 303: * @param[in,out] u8 *UpstreamLinkWidthLimit = modify to change the Link Witdh Out line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 304: * @param[in,out] u32 *PCBFreqCap = modify to change the link's frequency capability line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 403: * @param[in,out] u8 *LinkWidthIn = modify to change the Link Witdh In line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 404: * @param[in,out] u8 *LinkWidthOut = modify to change the Link Witdh Out line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 405: * @param[in,out] u16 *LinkFrequency = modify to change the link's frequency capability line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 434: * @param[in,out] u8 *LinkWidthIn = modify to change the Link Witdh In line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 435: * @param[in,out] u8 *LinkWidthOut = modify to change the Link Witdh Out line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 436: * @param[in,out] u16 *LinkFrequency = modify to change the link's frequency capability line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/amdht/h3finit.h@... PS3, Line 462: * @param[in] u8 *pEventData0 = useful data associated with the event. line over 80 characters
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/pi/agesawrapper_... File src/northbridge/amd/pi/agesawrapper_call.h:
https://review.coreboot.org/#/c/26461/3/src/northbridge/amd/pi/agesawrapper_... PS3, Line 35: const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED", char * array declaration might be better as static const
https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/fsp_sandybridg... File src/northbridge/intel/fsp_sandybridge/raminit.c:
https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/fsp_sandybridg... PS3, Line 24: static const char *ecc_decoder[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/haswell/ramini... File src/northbridge/intel/haswell/raminit.c:
https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/haswell/ramini... PS3, Line 65: static const char *ecc_decoder[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/#/c/26461/3/src/northbridge/intel/sandybridge/ra... PS3, Line 133: static const char *ecc_decoder[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/#/c/26461/3/src/southbridge/amd/sb700/sm.c File src/southbridge/amd/sb700/sm.c:
https://review.coreboot.org/#/c/26461/3/src/southbridge/amd/sb700/sm.c@51 PS3, Line 51: static const char *power_mode_names[] = { static const char * array should probably be static const char * const