Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32296 )
Change subject: mb/google/octopus: Add custom SAR values for Laser
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/32296/11/src/mainboard/google/octopus/varian...
File src/mainboard/google/octopus/variants/phaser/mainboard.c:
https://review.coreboot.org/#/c/32296/11/src/mainboard/google/octopus/varian...
PS11, Line 20: get_wifi_sar_cbfs_filename
For phaser, this will end up returning NULL which will default to wifi_sar_defaults.hex. But since that file is not present in CBFS, it will end up complaining that the file could not be found and skip adding SAR to ACPI. I believe that is already happening because USE_SAR is selected for all octopus boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cce38a191edfb235e274db3c788c58b65e0ebe1
Gerrit-Change-Number: 32296
Gerrit-PatchSet: 11
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Apr 2019 16:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment