Aaron Durbin (adurbin@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5384
-gerrit
commit 1b98a7a13db8718f4a8c6901ea5e5bbc868ebe7f Author: Aaron Durbin adurbin@chromium.org Date: Thu Mar 13 08:52:17 2014 -0500
cbfstool: remove incorrect section size check
I was overzealous in checking the section size with respect to the file size. That check makes no sense as the section only deals with link sizes -- not on-disk sizes. Remove the check as it doesn't make any sense.
Change-Id: I348e7847ae3a50badc22693439614f813462445a Signed-off-by: Aaron Durbin adurbin@chromium.org --- util/cbfstool/elfheaders.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/util/cbfstool/elfheaders.c b/util/cbfstool/elfheaders.c index 505af78..03d8e7d 100644 --- a/util/cbfstool/elfheaders.c +++ b/util/cbfstool/elfheaders.c @@ -306,11 +306,6 @@ shdr_read(const struct buffer *in, Elf64_Ehdr *ehdr, struct xdr *xdr, int bit64) for (i = 0; i < ehdr->e_shnum; i++) { DEBUG("Parsing section %d\n", i); elf_shdr(&b, &shdr[i], ehdr->e_shentsize, xdr, bit64); - - /* Ensure the contents are valid within the elf file. */ - if (check_size(in, shdr[i].sh_offset, shdr[i].sh_size, - "section contents")) - return NULL; }
return shdr;