Hello Andrey Petrov, Łukasz Siudut, Patrick Rudolph, Paul Menzel, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Huang Jin, David Hendricks, Philipp Deppenwiese, Nico Huber, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34636
to look at the new patch set (#3).
Change subject: mb/ocp/monolake: use RW_VPD to configure FSP UPD ......................................................................
mb/ocp/monolake: use RW_VPD to configure FSP UPD
Summary: This patch adds: * A framework to use VPD binary blob 2.0 data to configure FSP UPD. * A library to configure HyperThreading FSP UPD variable.
The framework is added in romstage to customize FSP UPD settings.
If RW_VPD and binary blob are not found, or if there is no "HyperThreading" setting in the binary blob, original configuration is used.
Test Plan: * Build an OCP MonoLake coreboot image, run following command to initialize RW_VPD and insert HyperThreading key: vpd -f build/coreboot.rom -O -i RW_VPD -s 'HyperThreading=0' * Flash the image to MonoLake, boot and observe following message in boot log: Detected 16 CPU threads
If RW_VPD partition does not exist, or if HyperThreading key/value pair does not exist, the boot log has: Detected 32 CPU threads
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I799d27734fe4b67cd1f40cae710151a01562b1b2 --- M src/mainboard/ocp/monolake/Makefile.inc M src/mainboard/ocp/monolake/romstage.c A src/mainboard/ocp/monolake/vpd_fsp.c A src/mainboard/ocp/monolake/vpd_fsp.h 4 files changed, 126 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/34636/3