Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37315 )
Change subject: vboot: update VbExNvStorageWrite function
......................................................................
Patch Set 3: Code-Review+2
I think the model recent patches have been going with is one plain revbump patch that uprevs to right in front of the dependent patch, and then only pull in the one extra patch that it's actually dependent on in the coreboot-changing patch. So that's what I went with there.
Yes, this is the way I've been doing it so far. If people don't care we can also just group the other submodule uprevs into the same patch, but I think that would make the uprevving more confusing and less explicit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2612da0df101cd3c46151dbce728633a39fada1
Gerrit-Change-Number: 37315
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Dec 2019 09:18:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment