Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40262 )
Change subject: soc/intel/tigerlake: Configure RP setting ......................................................................
soc/intel/tigerlake: Configure RP setting
Configure RP LTR and AER
BUG=b:151166040 TEST= build and boot volteer and check LTR and AER value from FSP log
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I668f2e5fea15019a9e5ae06fb4d55fa2aea69e8a --- M src/soc/intel/tigerlake/chip.h M src/soc/intel/tigerlake/fsp_params.c 2 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/40262/1
diff --git a/src/soc/intel/tigerlake/chip.h b/src/soc/intel/tigerlake/chip.h index e105061..259ebbe 100644 --- a/src/soc/intel/tigerlake/chip.h +++ b/src/soc/intel/tigerlake/chip.h @@ -118,6 +118,12 @@ L1_SS_L1_2, } PcieRpL1Substates[CONFIG_MAX_ROOT_PORTS];
+ /* PCIe LTR : Disable(1) / Enable(0) */ + uint8_t PcieRpLtrDisable[CONFIG_MAX_ROOT_PORTS]; + + /* PCIE RP Advanced Error Report: Enable(1) / Disable (1) */ + uint8_t PcieRpAdvancedErrorReporting[CONFIG_MAX_ROOT_PORTS]; + /* SMBus */ uint8_t SmbusEnable;
diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index ff6d3a9..da07d5f 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -122,10 +122,13 @@ }
/* RP Configs */ - for (i = 0; i < CONFIG_MAX_ROOT_PORTS; i++) + for (i = 0; i < CONFIG_MAX_ROOT_PORTS; i++) { params->PcieRpL1Substates[i] = get_l1_substate_control(config->PcieRpL1Substates[i]); - + params->PcieRpLtrEnable[i] = !config->PcieRpLtrDisable[i]; + params->PcieRpAdvancedErrorReporting[i] = + config->PcieRpAdvancedErrorReporting[i]; + } /* Enable xDCI controller if enabled in devicetree and allowed */ dev = pcidev_on_root(PCH_DEV_SLOT_XHCI, 1); if (dev) {