[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add chip config to override CPU flex ratio

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36864 )

Change subject: soc/intel/cannonlake: Add chip config to override CPU flex ratio
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36864/5/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/36864/5/src/soc/intel/cannonlake/ro... 
PS5, Line 79: flex_ratio = rdmsr(MSR_FLEX_RATIO);
> > please check the latest patch set. […]

because FIT has option to set the default value (other than 0) as well and if an user override FIT setting to change value to something else like 5 may be then in that case, i will fake and tell FSP its always 0, which might not be correct. So the purpose is FSP will read FIT value from MSR and pass into UPD to it know what is CPU operating freq.

if i do pass 0 here forcefully then there might be gap when user set 5 in FIT and FSP is reading 0 as CB fake that.