[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Configure miscellaneous features

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30774 )

Change subject: mb/google/hatch: Configure miscellaneous features
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/#/c/30774/8/src/mainboard/google/hatch/variants/... 
PS8, Line 53: # Enable heci communication
            : 	register "HeciEnabled" = "1"
> > this is just to ensure that FSP don't disable CSME interface before sending EOP which is not recom […]

oh yes, i just realized that Intel don't claim to disable CSME in boot flow hence there shouldn't be any UPD to disable CSME in boot flow.

but my concern is that hecienabled = 0 might not help here as well. can you please check ?