Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47259 )
Change subject: soc/intel/tigerlake: Update Kconfig for NEM Enhanced Mode
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47259/13/src/soc/intel/tigerlake/Kc...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47259/13/src/soc/intel/tigerlake/Kc...
PS13, Line 26: USE_CAR_NEM_ENHANCED_V1
You will need the mainboard Kconfig changes in the same file to ensure that the selection is correct […]
In the other CL, I selected INTEL_CAR_NEM for the boards using ESx. I did not select anything for boards using QS. I was about push that update for other CL. In such case, USE_CAR_NEM_ENHANCED_V1 selected in soc/Kconfig would be the final change, right? Are you suggesting to select USE_CAR_NEM_ENHANCED_V1 in volteer/Kconfig.name for boards using QS?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6e041261cb8ca9c6e602935da4962aac0d9ece5
Gerrit-Change-Number: 47259
Gerrit-PatchSet: 13
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Comment-Date: Wed, 11 Nov 2020 01:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment