Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42339 )
Change subject: soc/amd/picasso: fix build if PICASSO_UART is unset
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42339/2/src/soc/amd/picasso/uart.c
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42339/2/src/soc/amd/picasso/uart.c@...
PS2, Line 48: #endif /* PICASSO_UART */
Why are we guarding this w/ preprocessor macros? Can't we leave the implementations and rely upon the generic Kconfigs to honor not accessing these functions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1173034b0d2ed32f77241768e1e8abb208aac3a
Gerrit-Change-Number: 42339
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 16:11:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment