Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Paul Menzel, Ravi Kumar Bokka, Julius Werner.
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support
......................................................................
Patch Set 42:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45205/comment/f93778a1_f68ebabd
PS15, Line 8:
as per qcom policy, we are not permitted to share any document/ revision number externally. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/45205/comment/5bed6f20_52c33496
PS41, Line 8:
This is a completely new/different SoC. […]
Done
https://review.coreboot.org/c/coreboot/+/45205/comment/57f43f7a_c6088b6c
PS41, Line 10: TEST=Validated on qualcomm sc7280 developement board
You are correct, for this first patch, only build-tested is valid. […]
Done
https://review.coreboot.org/c/coreboot/+/45205/comment/96820cae_25255a32
PS41, Line 10: qualcomm sc7280 developement board
herobrine is the Google designation for this board, which has not been spun yet. […]
Done
File src/soc/qualcomm/sc7280/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/45205/comment/5040b278_405200c6
PS41, Line 30: 84K
We are expecting to add a 1K watchdog tombstone region here, which will come later, so for time bein […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fc841b3113f2bf79b8376cd1ccdb671c53c2084
Gerrit-Change-Number: 45205
Gerrit-PatchSet: 42
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 06 Apr 2021 12:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Comment-In-Reply-To: mturney mturney
mturney@codeaurora.org
Gerrit-MessageType: comment