Attention is currently required from: Evgeny Zinoviev, Felix Held.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support
......................................................................
Patch Set 41:
(1 comment)
File src/mainboard/apple/macbookair5_2/early_init.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/c6cf632a_059f8f71
PS41, Line 62: case 2:
I was helping a user on the libreboot IRC get their 8 GiB Hynix working, and they reported that the generated SPD from inteltool for it is exactly the same as the 4 GiB Samsung one. Adding `case 4:` as a fallthrough here did work for them. It's probably just a matter of the chips having similar timings and the 8 GiB config using dual vs single channel for the 4 GiB config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ebe6f87a8254871698be74f913b9d969d722447
Gerrit-Change-Number: 32604
Gerrit-PatchSet: 41
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 08 Apr 2023 02:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment